upgrades.js ➔ upgrades - Code Metrics - Inspection of "Components renamed" - angarg12/nucleogenesis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a14198...1b9c43 )

by Andres

created 2017-09-16 14:22 UTC

upgrades.js ➔ upgrades B

↳ Parent: src/scripts/component/upgrades.js

Complexity

Conditions	1
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	2
dl	0
loc	92
rs	8.491
nop	4

7 Functions

Rating	Name	Size	Complexity
A	upgrades.js ➔ ... ➔ ct.visibleUpgrades	3	1
A	upgrades.js ➔ ... ➔ ct.priceMultiplier	4	1
A	upgrades.js ➔ ... ➔ ct.canBuyGlobalUpgrade	11	3
A	upgrades.js ➔ ... ➔ ct.buyGlobalUpgrade	13	3
A	upgrades.js ➔ ... ➔ ct.buyUpgrade	10	1
A	upgrades.js ➔ ... ➔ createVisibleFunction	9	1
C	upgrades.js ➔ ... ➔ ct.buyAll	27	7

How to fix Long Method

/**
 upgrades
 Component that handles upgrades.

 @namespace Components
 */
'use strict';

angular.module('game').component('upgrades', {
  templateUrl: 'views/upgrades.html',
  controller: ['state', 'visibility', 'upgrade', 'data', upgrades],
  controllerAs: 'ct'
});

function upgrades(state, visibility, upgrade, data) {
  let ct = this;
  ct.state = state;
  ct.data = data;
  ct.hideBought = false;

  // tries to buy all the upgrades it can, starting from the cheapest
  ct.buyAll = function (element) {
    let currency = data.elements[element].main;
    let cheapest;
    let cheapestPrice;
    do{
      cheapest = null;
      cheapestPrice = Infinity;

      for(let up of ct.visibleUpgrades(element, data.upgrades)){
        let price = data.upgrades[up].price;
        if(!state.player.elements[element].upgrades[up] &&
          price <= state.player.resources[currency].number){
          if(price < cheapestPrice){
            cheapest = up;
            cheapestPrice = price;
          }
        }
      }
      if(cheapest){
        let upgrades = state.player.elements[element].upgrades;
        upgrade.buyUpgrade(state.player,
          upgrades,
          cheapest,
          cheapestPrice,
          currency);
      }
    }while(cheapest);
  };

  ct.buyUpgrade = function (name, element) {
    let upgrades = state.player.elements[element].upgrades;
    let price = data.upgrades[name].price;
    let currency = data.elements[element].main;
    upgrade.buyUpgrade(state.player,
      upgrades,
      name,
      price,
      currency);
  };

  /* Global upgrades are non-resource specific, repeatable upgrades */
  ct.buyGlobalUpgrade = function (name) {
    if (!ct.canBuyGlobalUpgrade(name)) {
      return;
    }

    let up = data.global_upgrades[name];
    for (let currency in up.price) {
      let value = up.price[currency] * ct.priceMultiplier(name);
      state.player.resources[currency].number -= value;
    }

    state.player.global_upgrades[name]++;
  };

  ct.canBuyGlobalUpgrade = function (name) {
    let up = data.global_upgrades[name];
    for (let currency in up.price) {
      let value = up.price[currency] * ct.priceMultiplier(name);
      if (state.player.resources[currency].number < value) {
        return false;
      }
    }

    return true;
  };

  ct.priceMultiplier = function (name) {
    let level = state.player.global_upgrades[name];
    return Math.ceil(Math.pow(data.global_upgrades[name].price_exp, level));
  };

  ct.visibleUpgrades = function(currentElement, source) {
    return visibility.visible(source, createVisibleFunction(source), currentElement);
  };

  function createVisibleFunction(source){
    return function isBasicUpgradeVisible(name, currentElement) {
      let isVisible = visibility.isUpgradeVisible(name, currentElement, source[name]);
      if(source === data.upgrades){
        return isVisible && (!ct.hideBought || !state.player.elements[currentElement].upgrades[name]);
      }
      return isVisible;
    };
  }
}


1			/**
2			upgrades
3			Component that handles upgrades.
4
5			@namespace Components
6			*/
7			'use strict';
8
9			angular.module('game').component('upgrades', {
10			templateUrl: 'views/upgrades.html',
11			controller: ['state', 'visibility', 'upgrade', 'data', upgrades],
12			controllerAs: 'ct'
13			});
14
15			function upgrades(state, visibility, upgrade, data) {
16			let ct = this;
17			ct.state = state;
18			ct.data = data;
19			ct.hideBought = false;
20
21			// tries to buy all the upgrades it can, starting from the cheapest
22			ct.buyAll = function (element) {
23			let currency = data.elements[element].main;
24			let cheapest;
25			let cheapestPrice;
26			do{
27			cheapest = null;
28			cheapestPrice = Infinity;
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-09-12 16:57 UTC by Report Bug Copy Issue Report You seem to be aliasing the built-in name `Infinity` as `cheapestPrice`. This makes your code very difficult to follow, consider using the built-in name directly. Loading history...
29			for(let up of ct.visibleUpgrades(element, data.upgrades)){
30			let price = data.upgrades[up].price;
31			if(!state.player.elements[element].upgrades[up] &&
32			price <= state.player.resources[currency].number){
33			if(price < cheapestPrice){
34			cheapest = up;
35			cheapestPrice = price;
36			}
37			}
38			}
39			if(cheapest){
40			let upgrades = state.player.elements[element].upgrades;
41			upgrade.buyUpgrade(state.player,
42			upgrades,
43			cheapest,
44			cheapestPrice,
45			currency);
46			}
47			}while(cheapest);
48			};
49
50			ct.buyUpgrade = function (name, element) {
51			let upgrades = state.player.elements[element].upgrades;
52			let price = data.upgrades[name].price;
53			let currency = data.elements[element].main;
54			upgrade.buyUpgrade(state.player,
55			upgrades,
56			name,
57			price,
58			currency);
59			};
60
61			/* Global upgrades are non-resource specific, repeatable upgrades */
62			ct.buyGlobalUpgrade = function (name) {
63			if (!ct.canBuyGlobalUpgrade(name)) {
64			return;
65			}
66
67			let up = data.global_upgrades[name];
68			for (let currency in up.price) {
69			let value = up.price[currency] * ct.priceMultiplier(name);
70			state.player.resources[currency].number -= value;
71			}
72
73			state.player.global_upgrades[name]++;
74			};
75
76			ct.canBuyGlobalUpgrade = function (name) {
77			let up = data.global_upgrades[name];
78			for (let currency in up.price) {
79			let value = up.price[currency] * ct.priceMultiplier(name);
80			if (state.player.resources[currency].number < value) {
81			return false;
82			}
83			}
84
85			return true;
86			};
87
88			ct.priceMultiplier = function (name) {
89			let level = state.player.global_upgrades[name];
90			return Math.ceil(Math.pow(data.global_upgrades[name].price_exp, level));
91			};
92
93			ct.visibleUpgrades = function(currentElement, source) {
94			return visibility.visible(source, createVisibleFunction(source), currentElement);
95			};
96
97			function createVisibleFunction(source){
98			return function isBasicUpgradeVisible(name, currentElement) {
99			let isVisible = visibility.isUpgradeVisible(name, currentElement, source[name]);
100			if(source === data.upgrades){
101			return isVisible && (!ct.hideBought \|\| !state.player.elements[currentElement].upgrades[name]);
102			}
103			return isVisible;
104			};
105			}
106			}
107

angarg12 / nucleogenesis

Push — master ( a14198...1b9c43 )

upgrades.js ➔ upgrades B

Complexity

Size

Duplication

Importance

7 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like